Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frame extraction tool for video processing #26

Merged
merged 7 commits into from
Mar 27, 2024
Merged

Add frame extraction tool for video processing #26

merged 7 commits into from
Mar 27, 2024

Conversation

humpydonkey
Copy link
Collaborator

No description provided.

dillonalaird
dillonalaird requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@dillonalaird dillonalaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just FYIs, I'd probably just delete the last if name part and then it looks good

vision_agent/tools/video.py Outdated Show resolved Hide resolved
vision_agent/tools/tools.py Show resolved Hide resolved
vision_agent/tools/video.py Show resolved Hide resolved
vision_agent/tools/video.py Outdated Show resolved Hide resolved
tests/tools/test_video.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
vision_agent/tools/tools.py Show resolved Hide resolved
dillonalaird
dillonalaird approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@dillonalaird dillonalaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@humpydonkey humpydonkey merged commit c8d9620 into main Mar 27, 2024
7 checks passed
@humpydonkey humpydonkey deleted the add-frame-extraction branch March 27, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillonalaird dillonalaird dillonalaird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@humpydonkey @dillonalaird @AsiaCao